Skip to content

chore: add group to readme#60

Merged
natemoo-re merged 2 commits into
mainfrom
chore/docs
Feb 17, 2023
Merged

chore: add group to readme#60
natemoo-re merged 2 commits into
mainfrom
chore/docs

Conversation

@cpreston321

Copy link
Copy Markdown
Collaborator

Updated README.md to include group function

@changeset-bot

changeset-bot Bot commented Feb 17, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 68c4867

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cpreston321 cpreston321 changed the title chore: update readme chore: add group to readme Feb 17, 2023

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@natemoo-re natemoo-re merged commit 94a46ac into main Feb 17, 2023
@natemoo-re natemoo-re deleted the chore/docs branch February 17, 2023 14:30

### Grouping

Grouping prompts together is a great way to keep your code organized. This accepts a JSON object with a name that can be used to reference the group later. The second argument is an optional but has a `onCancel` callback that will be called if the user cancels one of the prompts in the group.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This accepts a JSON object with a name that can be used to reference the group later.

I don't understand this part. Care to explain?

To me, there's only one group of named prompts.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was meaning to say the first argument accepts an object and for each key correlates to a prompt function that then can be referenced within the return.

Might need to change the wording but if you have any suggestions to simplify I'll make those changes.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, then we're on the same page regarding intended meaning. I don't think that's what it says right now, though.

It states the name can be used to reference the group, not the prompt.

I'll see what I can come up with.

On a related note, I think explanations of API parameters would be better suited for more structural API docs, but that's a whole other beast.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants